Skip to content

Preserve Liquid terminators after incomplete HTML tags - #1398

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/liquid-capture-html-1382
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/liquid-capture-html-1382

Conversation

@efegokdemir

Copy link
Copy Markdown

What are you adding in this PR?

Fixes #1382. Stop an incomplete HTML start tag from consuming its enclosing Liquid block terminator. Both parser implementations now report the boundary correctly, and the formatter regression fixture verifies that the source remains unchanged.

The TypeScript parser suite passed (1,588 tests; 4 skipped), the Prettier plugin suite passed (145 tests), and cargo test -p liquid-parser passed (9 unit tests, 542 shared specs and 1 doctest). The parser and plugin type-checks and plugin build passed.

What's next? Any followup issues?

None.

What did you learn?

The attribute parser treated endcapture as HTML attribute content while the start tag was incomplete, leaving the Liquid block open for the formatter to close at the end of the file.

Tophatting

No visible UI change; the formatting regression is covered by an automated fixture.

  • I added screenshots of the changes (before and after the changes if applicable)

Before you deploy

  • I included a patch bump changeset

@efegokdemir
efegokdemir requested a review from a team as a code owner November 13, 2026 00:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prettier appends an extra {% endcapture %} when a capture holds an unclosed HTML tag

1 participant