Repository navigation
Preserve Liquid terminators after incomplete HTML tags - #1398
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes #1382. Stop an incomplete HTML start tag from consuming its enclosing Liquid block terminator. Both parser implementations now report the boundary correctly, and the formatter regression fixture verifies that the source remains unchanged.
The TypeScript parser suite passed (1,588 tests; 4 skipped), the Prettier plugin suite passed (145 tests), and
cargo test -p liquid-parserpassed (9 unit tests, 542 shared specs and 1 doctest). The parser and plugin type-checks and plugin build passed.What's next? Any followup issues?
None.
What did you learn?
The attribute parser treated
endcaptureas HTML attribute content while the start tag was incomplete, leaving the Liquid block open for the formatter to close at the end of the file.Tophatting
No visible UI change; the formatting regression is covered by an automated fixture.
Before you deploy
changeset